Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Only one folding section for large file. #46687

Closed
dbaeumer opened this issue Mar 27, 2018 · 1 comment
Closed

[folding] Only one folding section for large file. #46687

dbaeumer opened this issue Mar 27, 2018 · 1 comment
Assignees
@aeschli
Labels
editor-folding Editor code folding issues json JSON support issues verified Verification succeeded
Milestone
May 2018

Comments

@dbaeumer
Copy link
Member

Testing #46588

Only one folding section for the top level array. Expected 5000.
@dbaeumer dbaeumer added the json JSON support issues label Mar 27, 2018
@aeschli aeschli changed the title Only on folding section for large file. [folding] Only on folding section for large file. Mar 28, 2018
@aeschli aeschli added the editor-folding Editor code folding issues label Mar 28, 2018
@aeschli aeschli added this to the Backlog milestone Mar 28, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2018

Problem is that there are 5000 regions on the second level.
I should at least take the first 4999

@aeschli aeschli modified the milestones: Backlog, April 2018 Mar 28, 2018
@dbaeumer dbaeumer changed the title [folding] Only on folding section for large file. [folding] Only one folding section for large file. Mar 28, 2018
@aeschli aeschli modified the milestones: April 2018, May 2018 Apr 18, 2018
@aeschli aeschli closed this as completed in ad24b14 May 7, 2018
aeschli added a commit to microsoft/vscode-html-languageservice that referenced this issue May 8, 2018
@aeschli
return max number of ranges (for microsoft/vscode#46687)
bc21773
aeschli added a commit to microsoft/vscode-json-languageservice that referenced this issue May 8, 2018
@aeschli
return max number of ranges (for microsoft/vscode#46687)
1863bf5
aeschli added a commit that referenced this issue May 8, 2018
@aeschli
[html] return max number of ranges (for #46687)
752acd5
@dbaeumer dbaeumer added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
editor-folding Editor code folding issues json JSON support issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@dbaeumer @aeschli