Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a fallback DOM renderer for terminal to use when GPU it turned off #46954

Closed
Tyriar opened this issue Mar 29, 2018 · 2 comments · Fixed by #50060
Closed

Provide a fallback DOM renderer for terminal to use when GPU it turned off #46954

Tyriar opened this issue Mar 29, 2018 · 2 comments · Fixed by #50060
Assignees
Labels
feature-request Request for new features or functionality gpu Issues concerning GPU related items on-testplan terminal General terminal issues that don't fall under another label
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 29, 2018

Upstream: xtermjs/xterm.js#1360

@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label gpu Issues concerning GPU related items labels Mar 29, 2018
@Tyriar Tyriar added this to the Backlog milestone Mar 29, 2018
@Tyriar Tyriar self-assigned this Mar 29, 2018
@micage
Copy link

micage commented Mar 31, 2018

It's not true that it takes very long. It does not get visible at all. I have to downsize the terminal pane to a certain size to make it visible again. In my case it's about 5-10 lines. Seems to me that the canvas is not resized properly. There are no problems if I disable GPU rendering (code --disable-gpu). Also without any noticeable performance issues.

Would be nice to have a flag in the preferences to disable GPU rendering as a quick workaround.

One of the reasons for using code (instead of Atom or Sublime) was the integrated terminal which seems to be broken since the new canvas rendering was introduced.

My System Config: OS X 10.11.6, GPU: NVidia 8800, 4GB RAM

@Tyriar
Copy link
Member Author

Tyriar commented May 11, 2018

@micage that will probably get fixed as part of this as well, it's probably something to do with your GPU/Chromium not liking the texture sizes above a certain size.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality gpu Issues concerning GPU related items on-testplan terminal General terminal issues that don't fall under another label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants