Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search tree context menu multiselect-aware #47166

Closed
roblourens opened this issue Apr 4, 2018 · 6 comments · Fixed by #154847
Closed

Make search tree context menu multiselect-aware #47166

roblourens opened this issue Apr 4, 2018 · 6 comments · Fixed by #154847
Assignees
@roblourens @andreamah
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan search Search widget and operation issues
Milestone
July 2022

Comments

@roblourens
Copy link
Member

We need the controller at https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/views/explorerViewer.ts#L369 to be not Explorer-specific so it can drive multiselect in other trees.

TreeResourceNavigator https://github.com/Microsoft/vscode/blob/master/src/vs/platform/list/browser/listService.ts#L456 kind of conflicts with it, need to figure out how that's supposed to work.

We will need a generic version of https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/browser/files.ts#L27 currently the keyboard shortcuts on some of the search context menu items don't work for the same reason
@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Apr 4, 2018
@roblourens roblourens added this to the April 2018 milestone Apr 4, 2018
@roblourens roblourens self-assigned this Apr 4, 2018
@roblourens roblourens modified the milestones: April 2018, May 2018 Apr 23, 2018
@roblourens roblourens modified the milestones: May 2018, June 2018 May 30, 2018
@roblourens roblourens modified the milestones: June 2018, Backlog Jun 28, 2018
@roblourens roblourens mentioned this issue Jul 22, 2019
Closed
@Stadly
Copy link

Stadly commented Jul 23, 2019

What would it take to get this out of the backlog and into a planned release?

@roblourens
Copy link
Member Author

A PR would help

@roblourens roblourens added the help wanted Issues identified as good community contribution opportunities label Jul 23, 2019
@qiangxi
Copy link

qiangxi commented Jul 27, 2019

Yeah, like issue #77749. In the search results, I want to be able to select multiple rows of search results and then copy them, this feature will be very useful.

Because not all search results can be used, such as some specific logs can indicate whether an application function is working properly. So if we have this feature, we can just select these specific logs and copy and paste them to the target location.

If you can release this feature, I am very grateful.

@roblourens roblourens mentioned this issue Oct 3, 2020
Open
@andreamah andreamah self-assigned this Jul 8, 2022
@kieferrm kieferrm mentioned this issue Jul 9, 2022
Closed
98 tasks
andreamah added a commit that referenced this issue Jul 11, 2022
@andreamah
Make search tree context menu multiselect-aware
352b418 
Fixes #47166
@andreamah andreamah mentioned this issue Jul 11, 2022
Merged
@andreamah andreamah modified the milestones: Backlog, July 2022 Jul 13, 2022
andreamah added a commit that referenced this issue Jul 21, 2022
@andreamah
Make search tree context menu multiselect-aware (#154847)
43fcb56 
* Make search tree context menu multiselect-aware
Fixes #47166

* move domFocus call out of loop

* PR feedback

* resolve strange post-replace bug

* cleaned up a bit but needs adjustment on post-replace focus

* adjusting ordering

* add replace action runner for all replace actions

* pr feedback

* fix list sorting and multiselect open replace preview

* whitespace cleanup

* tests and cleanup
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 21, 2022
@andreamah andreamah mentioned this issue Jul 25, 2022
Closed
3 tasks
@bpasero
Copy link
Member

bpasero commented Jul 29, 2022

I love this new addition 👏

@andreamah andreamah added the on-release-notes Issue/pull request mentioned in release notes label Jul 29, 2022
@Eskibear
Copy link
Member

Eskibear commented Aug 8, 2022

Multiselect in Search works well! One feedback is that I cannot batch undo the replacement in different files. Imagine I replaced multiple files with wrong text, it's painful for me to undo the changes one by one.

@andreamah andreamah mentioned this issue Aug 8, 2022
Closed
@andreamah
Copy link
Contributor

Multiselect in Search works well! One feedback is that I cannot batch undo the replacement in different files. Imagine I replaced multiple files with wrong text, it's painful for me to undo the changes one by one.

Made a new issue for this here #157533 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@andreamah andreamah

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan search Search widget and operation issues
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Make search tree context menu multiselect-aware microsoft/vscode
7 participants
@roblourens @bpasero @Eskibear @Stadly @qiangxi @andreamah @VSCodeTriageBot