Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a top-level Terminal menu for better discoverability #49477

Closed
Tyriar opened this issue May 8, 2018 · 6 comments · Fixed by #51513
Closed

Add a top-level Terminal menu for better discoverability #49477

Tyriar opened this issue May 8, 2018 · 6 comments · Fixed by #51513
Assignees
Labels
on-testplan terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 8, 2018

The purpose of a new "Terminal" menu would be to boost discoverability of the terminal itself and some of its features.

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach labels May 8, 2018
@Tyriar Tyriar added this to the May 2018 milestone May 8, 2018
@Tyriar Tyriar self-assigned this May 8, 2018
Tyriar added a commit that referenced this issue May 23, 2018
@Tyriar
Copy link
Member Author

Tyriar commented May 23, 2018

@Tyriar
Copy link
Member Author

Tyriar commented May 25, 2018

I more cut down alternative:

image

@Tyriar Tyriar changed the title Investigate top-level Terminal menu for better discoverability Add a top-level Terminal menu for better discoverability May 25, 2018
@Tyriar Tyriar modified the milestones: May 2018, June 2018 May 25, 2018
@Tyriar
Copy link
Member Author

Tyriar commented May 25, 2018

As part of this, some screenshots should be updated on the website to include the new menu.

@chpxu
Copy link

chpxu commented May 27, 2018

I personally feel that just adding a 'Terminal'button in the status bar at the bottom could. do some good too, since whilst I do like this top-level menu (first coming to VSCode, I had no idea how to open the terminal), a simple button which auto shows the terminal (or equivalent to dragging from bottom and clicking terminal/Create terminal [? ]) could be just as effective - this is a personal opinion however

@nijikokun
Copy link

I agree with @beastdestroyer because when you're using applications in full screen and using the four finger swipe mode with macOS, this menu is not visible unless you move your curser to the top, and for the majority of applications in this working environment you'll never do that except by accident.

Having it closer to the terminal and on the status bar would be much better.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 9, 2018

The problem with something in the status bar is that space is very limited and also then the terminal is treated a differently to problems, output, etc. Currently the terminal is visible when you have any panel open and also buried away in the view menu. Adding yet another button to the status bar which is already space limited (extensions contribute to it and currently has no overflow strategy) would contribute to bloat imo. I'll go ahead with the menu and see what feedback comes in from users of Insiders.

@Tyriar Tyriar mentioned this issue Jun 25, 2018
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants