Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace symbol list performs poorly for huge numbers of results #51236

Closed
DanTup opened this issue Jun 6, 2018 · 2 comments
Closed

Workspace symbol list performs poorly for huge numbers of results #51236

DanTup opened this issue Jun 6, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug perf tree-widget Tree widget issues
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Jun 6, 2018

This might be expected, but... :)

If I return around 80,000 items from my symbol provider, VS Code hangs really badly (frozen UI). It's not just JSON serialisation because getting it from my language server and parsing that JSON only takes a couple of seconds, but Code hangs for a long time.

For now, I'm going to truncate my results to about 500; however this isn't a perfect solution because VS Code doesn't allow me to give the user any indication that the results are truncated.

Some possible improvements:

  1. Allow symbol providers to indicate that the results are truncated and just tag a message along the bottom of the list
  2. Truncate the results yourself in Code, and tag a message along the bottom of the list
  3. See if you can make it perform better :) I don't know if it's easy to profile to figure out what's slow; are all the items added into the DOM always, or just a visible slice?

Anyway, not a big deal; but it'd be good to have some guidance on this. We can't control how big the projects are that our users open so if the guidelines are to truncate the results it'd be good if that was a bit more official.

DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Jun 6, 2018
@jrieken jrieken assigned joaomoreno and unassigned jrieken Jun 7, 2018
@jrieken
Copy link
Member

jrieken commented Jun 7, 2018

Yeah, it's our tree

@DanTup DanTup changed the title Workspace symbol provide performs poorly for huge numbers of results Workspace symbol list performs poorly for huge numbers of results Jun 7, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Jun 7, 2018
@joaomoreno joaomoreno added perf tree-widget Tree widget issues labels Jun 7, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Sep 14, 2018
@joaomoreno
Copy link
Member

Merging with #18180

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug perf tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

3 participants