Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS file path autocomplete not working after 1.24.0 release #51331

Closed
afisher88 opened this issue Jun 7, 2018 · 7 comments
Closed

SCSS file path autocomplete not working after 1.24.0 release #51331

afisher88 opened this issue Jun 7, 2018 · 7 comments
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality on-testplan
Milestone
August 2018

Comments

@afisher88
Copy link

- VSCode Version:
Version 1.24.0
Commit 6a6e02c
Date 2018-06-06T17:35:40.560Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

- OS Version:
Windows 10 Pro 64bit version 1803, OS Build 17134.48

Steps to Reproduce:

  1. Create a project with two SCSS files
  2. Use @import '../path/to/file/' to try to import one from another
  3. SCSS methods are suggested but not paths

This was working up until I updated to 1.24.0 today. Confirmed with no extensions enabled.

autocomplete

Does this issue occur when all extensions are disabled?: Yes
@afisher88 afisher88 changed the title SCSS file path autocomple not working after 1.24.0 release SCSS file path autocomplete not working after 1.24.0 release Jun 7, 2018
@vscodebot vscodebot bot added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Jun 7, 2018
@aeschli aeschli assigned octref and unassigned aeschli Jun 7, 2018
@octref octref added this to the June 2018 milestone Jun 7, 2018
@jacsamg
Copy link

jacsamg commented Jun 8, 2018

Yep!

@vittaljk
Copy link

Yeah facing the same issue

@shashikiran797
Copy link

+1

@anjapadu
Copy link

anjapadu commented Jun 15, 2018 •
edited
Loading

Similar issue. In my case it autocomplete routes but dont autocomplete component of imported libraries.

image

On the previous version it auto completed and auto-import the component from the imported Library.

It also does not autocomplete the props of the component :(
image

@adrianmui
Copy link

yep!

@octref octref added the feature-request Request for new features or functionality label Jun 20, 2018
@Lantain
Copy link

Lantain commented Jun 21, 2018

Same here!

@octref
Copy link
Contributor

octref commented Jun 25, 2018

We have completion for url() but not SCSS's import yet. For SCSS we also need some special handling of paths, because @import 'reset' actually imports _reset.scss.

Moving to July milestone.

@octref octref modified the milestones: June 2018, July 2018 Jun 25, 2018
@octref octref mentioned this issue Jul 11, 2018
Closed
@aeschli aeschli mentioned this issue Jul 24, 2018
Closed
@octref octref modified the milestones: July 2018, August 2018 Jul 31, 2018
@octref octref mentioned this issue Aug 7, 2018
Merged
@aeschli aeschli closed this as completed in a40bfc9 Aug 8, 2018
aeschli added a commit that referenced this issue Aug 8, 2018
@aeschli
Merge pull request #55971 from Microsoft/octref/css-import-completion
803ca90 
@import completion for css/scss/less. Fix #51331
@kieferrm kieferrm mentioned this issue Aug 20, 2018
Closed
39 tasks
@octref octref mentioned this issue Aug 28, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
9 participants
@Lantain @adrianmui @octref @afisher88 @aeschli @shashikiran797 @anjapadu @vittaljk @jacsamg