Typescript breakpoints no longer work since 1.25

[gombosg]

• VSCode Version: 1.25 & 1.26 Insiders. 1.24.1 is working properly.
• OS Version: Fedora 28 & Mac OS High Sierra (same symptoms)

Steps to Reproduce:

1. Start our Node.js server app via launch.json or attach to a process started from the terminal.
2. Try to set a breakpoint in the server .ts files.

Does this issue occur when all extensions are disabled?:
Yes, it's occurring with a vanilla Insiders Edition, too.

Our Typescript directory structure is the following:

• src/... - Typescript source files
• build/... - Built Javascript files
• build/src/... - Source maps

E.g. src/app.ts is the main source file, build/app.js is the Javascript, build/src/app.js.map is the source map.
The Javascript files point to the source maps at their end with a relative path e.g.

//# sourceMappingURL=../src/server/app.js.map`.

The source maps are built with gulp and they point to the exact absolute source path at their end e.g.

"sourceRoot": "/home/gombosg/myApp/src"`

outFiles is properly set in launch.json, but simply attaching to a running process worked, too.

This used to work perfectly, breakpoints always worked, but they appear as 'unverified' (greyed and hollow) since 1.25. Downgrading back to 1.24.1 helped though.

Let me know if you need some special logs.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Feature request: Provide more diagnostics information for source mapping (#5204)

[gombosg]

Well, it may not be connected to VSCode itself (but e.g. a Node debug adapter component) but something that has been working so far did break on a certain VSCode version update.

[gombosg]

I made a simple test case which works in 1.24 but doesn't work in 1.25.
tsTest.zip

Instructions:

• Run build.sh
• Set a breakpoint in build/hello.ts
• Run with F5, it's already configured.
• For me it stopped at the breakpoint in 1.24, didn't stop in 1.25.

[weinand]

@gombosg does your test case work in the latest Insiders?

[gombosg]

@weinand Nope. 1.25 and 1.26 Insiders seem to be affected.

[roblourens]

Apparently with the mapRoot and sourceRoot tsconfig options, tsc writes out absolute local paths for sourceMappingURL and sourceRoot. I think this is wrong, they should be file URIs and are usually relative paths. I just "fixed" this last month so that / urls can be resolved from the root of a webserver. Since tsc is doing this, I'll have to support this format too. This might be too late for 1.25.1 though.

[roblourens]

In my defense, Chrome devtools doesn't handle windows-style local paths which is what TS outputs on Windows, so I will file a bug on Typescript. It does on MacOS though.

[roblourens]

I filed microsoft/TypeScript#25587

[gombosg]

@roblourens Thanks a lot! Also, tsc can be configured from gulp etc. and absolute paths can be set anytime. I actually set absolutes source map paths in the gulp config file because it didn't work other way, it was trial and error. ☺️

[gombosg]

FYI as a quick fix I set the source map URLs in Gulp to relative by setting a relative sourceRoot in the appropriate sourcemaps.write command. This works with 1.25 properly. (But unlike the example I attached before, it's not a native tsconfig.json solution.)

[paustint]

I am also having the same issue. I was working on two typescript projects with different code-bases that have been working with breakpoints for at least the past year and both of them stopped working with the update. :(

I am not using gulp and don't plan to implement it for this issue. Any idea when this might be fixed so I can plan accordingly? (Or at least provide some workaround config I can use in my tsconfig)?

[paustint]

It appears that if I remove mapRoot from my tsconfig.json the breakpoints are properly handled and I can now debug again! :)

Here are my configs in case others experience issues to aid in possible troubleshooting.

Before

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "es7",
      "dom"
    ],
    "mapRoot": "../dist/server",
    "module": "commonjs",
    "moduleResolution": "node",
    "outDir": "../dist/server",
    "sourceMap": true,
    "strictNullChecks": false,
    "noUnusedLocals": false,
    "target": "es6",
    "typeRoots": [
      "../node_modules/@types",
      "./types"
    ]
  }
}

After

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "es7",
      "dom"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "outDir": "../dist/server",
    "sourceMap": true,
    "strictNullChecks": false,
    "noUnusedLocals": false,
    "target": "es6",
    "typeRoots": [
      "../node_modules/@types",
      "./types"
    ]
  }
}

[roblourens]

This will be fixed in TS' end in TS 3.0, but I'm trying to get a workaround out on our end in Insiders.

[paustint]

I think the issue I was experiencing was actually from issue #53785 and might be unrelated from what was reported in this ticket (unless this is a duplicate)

[roblourens]

@paustint Since you said it's related to mapRoot, this is probably the right issue.

[roblourens]

Please try this workaround for mac/linux. Add this to your launch config:

"pathMapping": {
    "/": "/"
}

You will get an warning that the property is "not allowed", ignore it.

[noambonnie]

@gombosg Life saver! changed path to relative in gulp and I have my breakpoints again. Thank you!

[jamietre]

Also having this problem - adding pathMapping has no effect for me (having this problem on mac). I'm not using gulp, though. Latest insiders doesn't work either. I'm running Jest tests using ts-jest and no breakpoints work since updating to 1.25.1 today. debugger also doesn't work.

[jamietre]

Never mind my comment above. This is actually a Jest problem for me. Unfortunately both vscode and Jest seem to have problems related to debugging in recent releases. For me, the latest release of vscode works with jest@22 + ts-jest but not jest@23.

jestjs/jest#6683

[roblourens]

There will be a fix in tomorrow's insiders build, please try it out.

[JacksonKearl]

I wasn't able to break with:

tsconfig.json:

{
    "include": [
        "src/**/*"
    ],
    "compilerOptions": {
        "sourceMap": true,
        "sourceRoot": "src/",
        "outDir": "build/",
        "mapRoot": "build/"
    }
}

but was after removing the mapRoot and sourceRoot entries.

[roblourens]

That is probably producing paths that are not correct. Also, what TS version? It's different after 3.

[JacksonKearl]

3.0.1

[roblourens]

Yeah with those options you get //# sourceMappingURL=../src/build/foo.js.map which is nonsense, mapRoot is more for when your build process is moving files around, and you need tsc to account for that, like the original repro example above.

[JacksonKearl]

Verified for TS@<3.0