-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in settings descriptions don't work for search results #55179
Comments
Nothing happens when clicking on a setting link that is filtered out
Nothing happens |
I'm not sure what should happen in that case. Clear the search query? That might be unexpected. |
I thought you are already doing it as said in the description |
Now it clears the search and focuses that setting. I'm not sure how I like that, it seems unexpected, but I'll try it out. I did fix the input box so that "undo" will work in this case and you can get your search query back. Another option would be to replace the search value with the key of the clicked setting, but that seems inconsistent from the normal way. |
From #54690 (comment)
If the setting is in the search results, we should reveal it. If it isn't, we should clear the search and reveal it.
The text was updated successfully, but these errors were encountered: