Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in settings descriptions don't work for search results #55179

Closed
roblourens opened this issue Jul 26, 2018 · 5 comments
Closed

Links in settings descriptions don't work for search results #55179

roblourens opened this issue Jul 26, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded

Comments

@roblourens
Copy link
Member

From #54690 (comment)

  • Do a search in the settings editor
  • Click a link
  • Nothing happens

If the setting is in the search results, we should reveal it. If it isn't, we should clear the search and reveal it.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jul 26, 2018
@roblourens roblourens added this to the July 2018 milestone Jul 26, 2018
@roblourens roblourens self-assigned this Jul 26, 2018
@roblourens roblourens mentioned this issue Aug 3, 2018
38 tasks
@roblourens
Copy link
Member Author

6f010b0

@sandy081 sandy081 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Aug 29, 2018
@sandy081
Copy link
Member

Nothing happens when clicking on a setting link that is filtered out

  • Search for detect inde
  • Click on the links in the description of indentation setting.

Nothing happens

@roblourens
Copy link
Member Author

I'm not sure what should happen in that case. Clear the search query? That might be unexpected.

@sandy081 sandy081 reopened this Aug 30, 2018
@sandy081
Copy link
Member

I thought you are already doing it as said in the description

@bpasero bpasero modified the milestones: August 2018, September 2018 Aug 30, 2018
@roblourens
Copy link
Member Author

Now it clears the search and focuses that setting. I'm not sure how I like that, it seems unexpected, but I'll try it out. I did fix the input box so that "undo" will work in this case and you can get your search query back.

Another option would be to replace the search value with the key of the clicked setting, but that seems inconsistent from the normal way.

@roblourens roblourens removed the verification-found Issue verification failed label Sep 5, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants