Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore how setting categories are formatted #55800

Closed
roblourens opened this issue Aug 4, 2018 · 4 comments
Closed

Explore how setting categories are formatted #55800

roblourens opened this issue Aug 4, 2018 · 4 comments
Assignees
Labels
settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Aug 4, 2018

This came up in #54690 (comment) and #55616 (comment)

tl;dr, we show settings with some category context that's dynamically computed based on the sections its in. In the flat search mode, we show the full category from the setting key but not the TOC category.

  • Should we show the TOC category somewhere in the flat search mode?
  • Should the category with multiple components be formatted differently? e.g. instead of Editor.Hover: Delay, Editor > Hover: Delay or something like that? Not a fan of the dot here especially when a component contains spaces. Workbench.Command Palette: History looks wrong
  • Since we updated the category opacity to meet color contrast guidelines, the categories are harder to skim/parse out visually. Anything we can do about that?
  • Acronyms like IE and CSS should be formatted in all caps, where they are extracted from the setting key.
@roblourens roblourens added settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach labels Aug 4, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 4, 2018
@roblourens roblourens mentioned this issue Aug 4, 2018
38 tasks
@chpxu
Copy link

chpxu commented Aug 4, 2018

Hi @roblourens, I prefer the arrow, I think it'd be a better choice since it'll show a hierarchy of the settings better and it won't get weird like you mentioned.

Also for the colour contrast, what about when you click on a setting, the background of that box transitions to something else?

Maybe add some hr tags to denote ends/beginnings of sections too?

@roblourens
Copy link
Member Author

roblourens commented Aug 13, 2018

Extra line?

image

Basic gt sign:

image

Monospace gt sign:

image

Unicode "division slash":

image

Dot:

image

Filled in arrow:

image

Fancy arrows:

image

image

image

👇👇👇

image

@roblourens
Copy link
Member Author

@misolori we lost some of the color contrast in the category, to fit the color contrast accessibility guidelines. I thought the setting names got harder to scan when we made that change. Do you think it would be ok to use the brighter "highlight" white color from the section titles and TOC selected item for the setting label?

Would look like this:

image

@roblourens
Copy link
Member Author

Should we show the TOC category somewhere in the flat search mode?

Feels too noisy, redundant in some cases.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants