-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build perf #75983
Comments
Removing old extensions build and deduping extension webpacking across all three targets brought the build time down from 1114s to 379s: 3x speedup. |
Deduping TypeScript compilation brought it further down to 264s: 4x speedup. |
Merged deduplication effort. Here are the improvements for the build step, given two sample builds:
|
Adding Yarn cache:
|
Here are some really exciting numbers for the shared agent which runs hygiene checks, telemetry gathering and core & extensions compilation:
Platform specific agents can just pick up this agent's work and proceed with testing, packaging, signing and publishing. |
Some more preliminary numbers, for total build times:
There's still a bit more to go through. We're still compiling extensions twice unnecessarily, for example. |
Several perf problems with the build that need to be addressed:
node.exe
gets downloaded 2 timesSubmitted bundle stats
)DONE ✔️
VSCODE_WEB
hack, createvscode-web-*
tasksVSCODE_COMPILE_ONLY
flagnode build/lib/builtInExtensions.js
quality/*/package.json
dependencies into actual package.json dependenciesMove bundle stats to common agentMove upload-configuration to common agentThe text was updated successfully, but these errors were encountered: