Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension tests are not running in a windows docker container #77499

Closed
BugDiver opened this issue Jul 17, 2019 · 7 comments
Closed

Extension tests are not running in a windows docker container #77499

BugDiver opened this issue Jul 17, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions-development Issues for developing extensions *out-of-scope Posted issue is not in scope of VS Code

Comments

@BugDiver
Copy link

  • VSCode Version: 1.36.1
  • OS Version: Windows Server Core ltsc2016

Steps to Reproduce:

  1. Start a windows docker container
  2. Install yo, generator-code
  3. Create a sample extension
  4. npm install and npm test
  5. The error is as following
Downloading VS Code 1.36.1 from https://update.code.visualstudio.com/1.36.1/win32-archive/stable
Downloaded VS Code 1.36.1 into .vscode-test/vscode-1.36.1
Exit code:   3221225781
Done

Failed to run tests
npm ERR! Test failed.  See above for more details.

Note

The tests works fine when the vscode engine in package.json is 1.35.1.

@octref
Copy link
Contributor

octref commented Jul 17, 2019

Working for me on Windows 10 though.

PS C:\Users\octref\Desktop\foo> yarn test
yarn run v1.13.0
warning package.json: No license field
$ npm run compile

> foo@0.0.1 compile C:\Users\octref\Desktop\foo
> tsc -p ./

$ node ./out/test/runTest.js
Downloading VS Code 1.36.1 from https://update.code.visualstudio.com/1.36.1/win32-archive/stable
Downloaded VS Code 1.36.1 into .vscode-test/vscode-1.36.1


[main 2019-07-17T21:24:13.829Z] update#ctor - updates are disabled by user preference




  Extension Test Suite

    √ Sample test




  1 passing (10ms)


Exit code:   0
Done

Done in 92.34s.
PS C:\Users\octref\Desktop\foo>

Where can I find docker for Windows Server Core ltsc2016? Also this error code gave me some issues when people generally run apps in Docker:

So I'm not sure this is a VS Code issue.

@octref octref added the info-needed Issue requires more information from poster label Jul 17, 2019
@BugDiver
Copy link
Author

@octref Thanks for the quick reply.

The tests work perfectly fine on a windows machine for me as well. The issue is only when we try to run it in a docker container (windows)

Where can I find Docker for Windows Server Core ltsc2016?

It can be pulled from the docker hub. docker pull mcr.microsoft.com/windows/servercore:ltsc2016

The weird part is all the test passes with vscode version 1.35.1 with the same setup. (I use CODE_VERSION env to set the vscode version for tests.)

Does vscode 1.36.1 require some new dep (dll's) on windows?

@octref
Copy link
Contributor

octref commented Jul 25, 2019

There's another bug report saying 1.35.1 works fine but 1.36.0 doesn't: #77513

So, just to recap, this setup:

  • Works fine with both 1.35.1 and 1.36.1 locally
  • Works fine on container with 1.36.1, but not 1.36.1

Is this correct?

Also I'm not familiar with Windows Server Core, but would it have problem launching 32-bit VS Code? Currently vscode-test by default downloads 32-bit archive for Windows.

@BugDiver
Copy link
Author

So, just to recap, this setup:

  • Works fine with both 1.35.1 and 1.36.1 locally
  • Works fine on container with 1.36.1, but not 1.36.1

Yes, just that the second point is a bit wrong
It is Works fine on container with 1.35.1, but not 1.36.1

Also I'm not familiar with Windows Server Core, but would it have a problem launching 32-bit VS Code?

I'm not sure about that but since it works with 1.35.1 I guess it can launch.

@octref octref added this to the August 2019 milestone Aug 1, 2019
@octref octref modified the milestones: August 2019, September 2019 Aug 27, 2019
@octref octref modified the milestones: September 2019, October 2019 Sep 30, 2019
@chrmarti chrmarti removed their assignment Oct 24, 2019
@octref octref added bug Issue identified by VS Code Team member as probable bug extensions-development Issues for developing extensions and removed info-needed Issue requires more information from poster labels Oct 25, 2019
@octref octref modified the milestones: October 2019, November 2019 Oct 25, 2019
Glavin001 added a commit to Unibeautify/vscode that referenced this issue Apr 25, 2020
@Glavin001
Copy link

Is there a workaround for this? If I force engines to be <= 1.35.1 then the extension would not be installable by newer VSCode versions? https://github.com/Unibeautify/vscode/blob/master/package.json#L67

valentjn added a commit to valentjn/vscode-ltex that referenced this issue May 17, 2020
valentjn added a commit to valentjn/vscode-ltex that referenced this issue May 24, 2020
@Tyriar Tyriar assigned eamodio and unassigned octref Aug 26, 2020
@hunterwerlla
Copy link

hunterwerlla commented Oct 26, 2020

Is there an update on this? We are still having this happen in Windows Docker containers making our CI a pain.

@lramos15 lramos15 assigned chrmarti and unassigned eamodio Oct 8, 2021
@chrmarti chrmarti added the *out-of-scope Posted issue is not in scope of VS Code label Oct 20, 2021
@chrmarti chrmarti removed this from the Backlog milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug extensions-development Issues for developing extensions *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

7 participants
@eamodio @Glavin001 @octref @chrmarti @hunterwerlla @BugDiver and others