Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add extra line to find text box in find widget #79893

Closed
stevencl opened this issue Aug 27, 2019 · 1 comment
Closed

Cannot add extra line to find text box in find widget #79893

stevencl opened this issue Aug 27, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@stevencl
Copy link
Member

Issue Type: Bug
Testing #79831

Copy a multiline selection from the editor and paste into the find input box of the find widget.

The find widget shows multiple lines as expected.

Try adding a new line with shift+enter - nothing happens
Try adding a new line with ctrl+enter - nothing happens

Shift focus to the replace text box and paste in the same multi line text from the clipboard. The replace text box shows multiple lines as expected.

Try adding a new line with shift+enter - a new line is added

I expected to be able to add a newline in the find text box the same way I was able to do in the replace text box.

VS Code version: Code - Insiders 1.38.0-insider (8cd00a7, 2019-08-27T06:13:54.903Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.93GB (4.42GB free)
Process Argv
Screen Reader yes
VM 0%
Extensions (12)
Extension Author (truncated) Version
tslint eg2 1.0.44
vscode-github-releases-updater joa 0.17.0
vscode-docker ms- 0.7.0
python ms- 2019.8.30787
remote-containers ms- 0.69.0
remote-ssh ms- 0.45.6
remote-ssh-edit ms- 0.45.6
remote-ssh-explorer ms- 0.45.6
remote-wsl ms- 0.39.4
vscode-remote-extensionpack ms- 0.16.0
azure-account ms- 0.8.4
test-search-rg rob 0.0.3
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 28, 2019
@rebornix
Copy link
Member

I pushed a fix for pressing ctrl+enter when the cursor is at the beginning of the find input box. Previously it doesn't insert a new line but now it does.

Shift+Enter is bind to Go to Previous Result by default, if you wish to use this one in the same way as other textareas, you can now unbind it from the command

	{
		"key": "shift+enter",
		"command": "-editor.action.previousMatchFindAction",
		"when": "editorFocus && findInputFocussed"
	}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants