Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive replace makes window unresponsible and then crashes the window #8529

Closed
kieferrm opened this issue Jun 29, 2016 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority search Search widget and operation issues
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Jun 29, 2016

Testing #8184.

  • VSCode Version: Insiders 6/29
  • OS Version: Windows

Steps to Reproduce:

  1. Use a large code base such as the vscode repo
  2. "View: Show Search"
  3. Expand Search
  4. Enter a as search string
  5. Enter b as replace string
  6. Press Enter
  7. Wait for the search to finish
  8. Press Replace All

screen shot 2016-06-29 at 10 36 32 am

Then:
screen shot 2016-06-29 at 10 37 27 am

Eventually the window will crash.

We should have safeguards against this kind of abuse. Independently, the window should never become unresponsive.

@kieferrm kieferrm changed the title Massive replace first makes the window unresponsible and then crashes the window Massive replace makes window unresponsible and then crashes the window Jun 29, 2016
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority search Search widget and operation issues labels Jun 30, 2016
@egamma egamma added this to the June 2016 milestone Jun 30, 2016
@sandy081
Copy link
Member

There are two parts for this issue

@sandy081
Copy link
Member

With above fixes there wont be crash or slowness. Created investigation item #8563 to lift the limitation

@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants