Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing Max results limitation for Search and replace results #8563

Closed
sandy081 opened this issue Jun 30, 2016 · 11 comments · Fixed by #126762
Closed

Investigate removing Max results limitation for Search and replace results #8563

sandy081 opened this issue Jun 30, 2016 · 11 comments · Fixed by #126762
Assignees
@roblourens
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2021

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 30, 2016 •
edited by roblourens
Loading

Investigate removing Max results limitation for Search and replace results

Currently we set max limit to 10000. We need to investigate on lifting this.
@sandy081 sandy081 added feature-request Request for new features or functionality search Search widget and operation issues labels Jun 30, 2016
@sandy081 sandy081 added this to the July 2016 milestone Jun 30, 2016
@sandy081 sandy081 mentioned this issue Jun 30, 2016
Closed
@sandy081 sandy081 modified the milestones: Backlog, July 2016 Jul 6, 2016
@sandy081 sandy081 assigned chrmarti and unassigned sandy081 Jul 22, 2016
@sandy081
Copy link
Member Author

@chrmarti Assigning this to you.

I see that you are working on improving the performance for Search results. Currently we have an hard limitation of 2048. But we never measure what is the threshold. Since you are already exercising Search performance this would be a good one to look at.

Thanks

@haerfest
Copy link

I noticed #8529. An improvement may be to not open all files in which terms were found and replaced. As a software engineer myself I sometimes have to make many changes (just today some 33k machine names in 280 XML files).

Version 1.3.1 crashed on me, but even if it had worked, I would have stared at many open files. And there's no shortcut to "save all" and "close all" :(

I had to revert to Notepad++, which simply makes the changes in-place on disk, without opening all files. Maybe doing something similar is an option?

@chrmarti chrmarti assigned roblourens and unassigned chrmarti Nov 30, 2017
@roblourens roblourens mentioned this issue Sep 22, 2018
Closed
@nkkollaw
Copy link

This would be nice to fix/improve.

I have to open Atom just to do find/replace.

@roblourens roblourens mentioned this issue Oct 10, 2019
Closed
@markdreyer
Copy link

There should at least be a warning telling the user that not all the occurrences have been replaced. It is very misleading when "Replace All" only replaces the first 10000 items.

@NiklasBr
Copy link

Please increase this number or make it configurable

@nyghtly-derek nyghtly-derek mentioned this issue Feb 10, 2020
Closed
@vscodebot vscodebot bot mentioned this issue Feb 10, 2020
Open
@agrexgh
Copy link

agrexgh commented Oct 21, 2020

Same here.
I'd like you to make the number configurable.
I'd like to set this to "No Limit" also, hopefully.

@ali3nnn
Copy link

ali3nnn commented Nov 10, 2020

The current upper bound for search in VSCode is 19999 occurrences. Is there a way to change it?

@skupjoe
Copy link

skupjoe commented Feb 8, 2021

Please make this maximum / upper boundary configurable.

@rickpmartin rickpmartin mentioned this issue Jun 20, 2021
Merged
@roblourens roblourens modified the milestones: Backlog, June 2021 Jun 22, 2021
@rzhao271
Copy link
Contributor

I wonder what search.maxResults is measuring?

maxres

Also, when I set it to 2000, I see 4000 results show up when I search a single letter. @roblourens

@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jun 29, 2021
@roblourens
Copy link
Member

You will also get results in open files beyond the limit

@jrieken jrieken added the verified Verification succeeded label Jun 30, 2021
@jrieken
Copy link
Member

jrieken commented Jun 30, 2021

This is a bit of a foot gun... Using some ridicules high value freeses VS Code eventually. Will create a separate issue for that

@jrieken jrieken mentioned this issue Jun 30, 2021
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Add search.maxResults setting rickpmartin/vscode
13 participants
@NiklasBr @roblourens @nkkollaw @haerfest @jrieken @markdreyer @skupjoe @rzhao271 @chrmarti @sandy081 @ali3nnn @agrexgh and others