Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: wrapping using the DOM #89389

Closed
2 tasks done
alexdima opened this issue Jan 27, 2020 · 2 comments
Closed
2 tasks done

Test: wrapping using the DOM #89389

alexdima opened this issue Jan 27, 2020 · 2 comments

Comments

@alexdima
Copy link
Member

alexdima commented Jan 27, 2020

Test for #2654

Complexity: 3

There is a new setting, editor.wrappingAlgorithm that can be configured to dom (as opposed to the default monospace), in which case the editor will delegate wrapping points computation to the DOM. This will be slow/laggy for large files.

Please check that using "editor.wrappingAlgorithm": "dom":

  • characters outside Latin / emojis wrap better now when using a monospace font
  • using non-monospace fonts leads to correct wrapping
  • changing the wrapping algorithm will rerun the wrapping points computation
  • please also try some RTL text as well
  • please also leave any feedback about the setting name / setting value / setting description if you have ideas.

Thank you!

@qaqz111
Copy link

qaqz111 commented Jan 28, 2020

Insiders version:
0

The word wrapping just totally stop working while turn on "editor.wrappingAlgorithm": "dom":

The font family Simsun's space chararacter is recogonized as fullwidth which should be halfwidth, this leads to the wrong wrapping point at Couri[e]r. Vscode stable 1.41.1 also got this issue.
1

After turn on dom option, line7 and line8 just stop wrapping while line3 is still wrapping with above issue.
2

As a contrast, the above issues are all gone while font family set to Consolas:
3

But wrapping still not work for line7 and line8:
4

settings.json

{
    //"editor.wrappingAlgorithm": "dom",
    "editor.fontFamily": "Simsun, Consolas, 'Courier New', monospace",
//12345678
    "editor.fontSize": 20
}
//12345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678123456781234567812345678
//“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’“”‘’123456781234567812345678

@alexdima
Copy link
Member Author

@qaqz111 This now works correctly for me after the changes for #89571

image

Please open a new issue if you observe something is off. Thank you!

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants