Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom-based wrapping: long words don't wrap #89571

Closed
kieferrm opened this issue Jan 28, 2020 · 1 comment
Closed

Dom-based wrapping: long words don't wrap #89571

kieferrm opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-wrapping Editor line wrapping issues verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Jan 28, 2020

Testing #89389.

  1. Enable line wrapping by setting it to bounded
  2. Type a single number that is longer than the viewport/wrap column
    -> when using dom for wrapping than there is no wrapping while in monospace the line is wrapped; this is not only true for numbers but also for strings of ascii characters. When using Chinese however, wrapping is working fine.

This screenshot shows three lines

image

What I also realize is that for most font families (such as Source Code Pro or Courier or AppleGothic), the last 2-4 characters of such long numbers (when no line is longer) are not revealed in the viewport neither by scrolling nor while moving the cursor with the arrow keys.

The line below end on 0 and the viewport is scrolled all the way to the right:

image

@sana-ajani
Copy link
Contributor

Trying on Windows machine, I set line wrapping to "wordWrapColumn", wordWrapColumn to "100", and the algorithm setting to "dom" and using characters, numbers, or in Arabic (RTL), there is no wrapping.

image

@alexdima alexdima added the editor-wrapping Editor line wrapping issues label Jan 29, 2020
@alexdima alexdima added this to the January 2020 milestone Jan 29, 2020
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jan 29, 2020
alexdima added a commit that referenced this issue Jan 30, 2020
@rebornix rebornix added verified Verification succeeded and removed verified Verification succeeded labels Jan 30, 2020
@eamodio eamodio added the verified Verification succeeded label Jan 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-wrapping Editor line wrapping issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants