Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: debug progress events #92914

Closed
2 tasks done
isidorn opened this issue Mar 18, 2020 · 2 comments
Closed
2 tasks done

Test: debug progress events #92914

isidorn opened this issue Mar 18, 2020 · 2 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 18, 2020

Refs: #92253

Complexity: 4


VS Code now shows debug progress events via silent progress notifications.
Have a debug extensions that implements Progress Events, or use and modify the Mock Debug Extension https://github.com/microsoft/vscode-mock-debug (progress event is started by typing progress in debug console after staring a debug session).

Verify:

  • VS Code shows progress with a 500 ms timeout (motivation here Notifications: if finished before delay starts the notification still shows briefly #93029)
  • VS Code shows an infinity blue spinner in the debug viewlet as long as there is an active progress event
  • Have multiple progress events started simultaneously and make sure VS Code represents this correctly
  • VS Code show a silent progress notification for each progress event
  • If a progress event is cancellable make sure VS Code renders a Cancel button in the notification and pressing Cancel stops the progress
  • Make sure the label of the debug extension is rendered as the source for the notification
  • A progressUpdate event is respected (check that message gets updated)
  • if the elapsed time between progressStart and progressEnd is shorter than 500 ms no progress is shown at all.
  • Optional: check that progressUpdateEvent with percentage attribute is respected
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 2, 2020

Didn't see any issues in my testing on MacOS. Compound debugs with progress also worked great

@mjbvz mjbvz closed this as completed Apr 2, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Apr 2, 2020

Thanks for testing it out 👏

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants
@isidorn @connor4312 @JacksonKearl @mjbvz and others