Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If progress is cancelled but does not manually emit an end event, the debug view remains 'busy' #94022

Closed
connor4312 opened this issue Mar 31, 2020 · 2 comments
Closed

If progress is cancelled but does not manually emit an end event, the debug view remains 'busy' #94022

connor4312 opened this issue Mar 31, 2020 · 2 comments
Assignees
@isidorn
Labels
*as-designed Described behavior is as designed debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@connor4312
Copy link
Member

Refs: #92914

  1. Have a progress event
  2. Cancel it, and don't manually send a progressEnd after cancellation from the debug adapter
  3. The debug view gets stuck as being "busy"

https://memes.peet.io/img/20-03-659125af-4489-4877-83c7-874ed6036e4e.webm
@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020

This is designed behavior, since we can not assume that the debug adapter trully canceled the progress.
I am open to suggestions here
Currently we will complete the progress if the session goes down, which is fair.

fyi @weinand

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Apr 1, 2020
@connor4312
Copy link
Member Author

connor4312 commented Apr 1, 2020 •
edited
Loading

Nevermind, I saw in the specification that it says

The progress that got cancelled still needs to send a ‘progressEnd’ event back.

So not sending it was a bug on me :)

@connor4312 connor4312 added the *as-designed Described behavior is as designed label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
*as-designed Described behavior is as designed debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isidorn @connor4312