Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell navigation should always be done in visual not historical order #93938

Closed
isidorn opened this issue Mar 31, 2020 · 3 comments
Closed

Cell navigation should always be done in visual not historical order #93938

isidorn opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach wont-fix
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

  1. Have a notebook file with multiple cells, have an error in each cell. Re-arange the cells such that they are not ordered in the way they got created
  2. Notice how the error jumping is done based on historical creation time (cell 0, before cell 1 before cell 2...). It should be done in a vertical order so it makes sense for the user and is not surprising

nextError

@jrieken jrieken added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 31, 2020
@jrieken
Copy link
Member

jrieken commented Mar 31, 2020

This would require us to rename cells when re-ordering them, e.g close a files and create new once or swap contents...

@rebornix rebornix added this to the April 2020 milestone Mar 31, 2020
@rebornix rebornix removed their assignment Apr 24, 2020
@jrieken jrieken modified the milestones: April 2020, May 2020 Apr 29, 2020
@jrieken
Copy link
Member

jrieken commented May 4, 2020

@rebornix For nicer cell numbers I want to make _cellhandlePool and instance-field, not a static field. I believe that is OK to do because we only use the cell handle in the context of a notebook, never as "global" identifier but I wanna double check with you before making such a change

@jrieken
Copy link
Member

jrieken commented Jun 24, 2020

We won't fix this for the foreseeable future. What would be required to get this right is some sort of pluggable sort order provider. However, that would need to do a lookup (expensive) when sorting URIs of notebooks because the order isn't obvious anymore

@jrieken jrieken closed this as completed Jun 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook under-discussion Issue is under discussion for relevance, priority, approach wont-fix
Projects
None yet
Development

No branches or pull requests

3 participants