Timeline pin state

[kieferrm]

Issue Type: Feature Request

Testing #93819

Related to #94091.

1. Open a timeline from a file in the explorer
2. Hover over the timeline titlebar
   -> you see

The unpin icon has a couple of issues:
-> The action icon indicates the current state: "I don't follow the active editor" rather than the action it represents.
-> The eye icon to me is not obvious. I have to use it to figure out what it's doing.

I propose we explore using the concept of "pinning" with an appropriate visual presentation.

VS Code version: Code - Insiders 1.44.0-insider (d7d1147, 2020-03-31T08:22:34.682Z)
OS version: Darwin x64 18.7.0
Remote OS version: Linux x64 5.0.0-1022-azure
Remote OS version: Linux x64 5.0.0-1022-azure

[miguelsolorio]

Funny, I also filed #94049 today and agree

[eamodio]

I'm a little concerned with using the "pinned" metaphor, as I would expect "pinning" a view, would stop the view from collapsing or something along those lines. I feel like what you are doing is tracking or following -- and we use the follow terminology with the Outline view -- "Follow Cursor"

Visual Studio use the "Track" terminology -- they have a "Track Active Item in Solution Explorer" setting

[miguelsolorio]

The action Toggle Active Editor Following is really oddly phrased, especially since the "follow" concept is really new to the editor. Follow Cursor is different because as you move your cursor the view gets updated. That is not the case in the timeline view because the view doesn't change at all. The action basically means "Stay here and don't move/change", and that resembles the "pinned" metaphor more. I'd almost argue that the "follow" metaphor contradicts the Outline view because it doesn't follow you wherever you go, which is what that actual word means.

I think something like "Pin Active Editor" feels more appropriate.

[eamodio]

I'm confused -- this is very similar to the Follow Cursor of the Outline view -- just less granular, instead of following the cursor position exactly it is following the cursor focus. And the view will update automatically as focus changes, just like the Outline does when the cursor and/or focus changes.

[eamodio]

If we do decide to switch to a "pin" metaphor we will need a pin/unpin icon -- we currently only have 1

[miguelsolorio]

We can certainly create a new "pin" and "unpin" icon. I think this comes down whether that's the direction we want to head towards (which I'm personally in favor of doing).