Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show in IE11 #10309

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Fix show in IE11 #10309

merged 1 commit into from
Aug 16, 2016

Conversation

sandyarmstrong
Copy link
Member

Setting element.style.display to null in IE11 has no effect.
So if the suggest widget was hidden for some reason, and then
shown again, it just stayed hidden.

This issue also prevented the "No suggestions" message from displaying.

Fixes: microsoft/monaco-editor#96

@msftclas
Copy link

msftclas commented Aug 8, 2016

Hi @sandyarmstrong, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Sandy Armstrong). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@sandyarmstrong
Copy link
Member Author

I used '' for consistency with other code from this repo (see goToError.ts and extensionsList.ts), but maybe initial or unset would be more appropriate.

Setting `element.style.display` to `null` in IE11 has no effect.
So if the suggest widget was hidden for some reason, and then
shown again, it just stayed hidden.

This issue also prevented the "No suggestions" message from displaying.

Fixes: microsoft/monaco-editor#96
@alexdima
Copy link
Member

Nice catch! Thank you!

@alexdima alexdima merged commit 375f17e into microsoft:master Aug 16, 2016
@alexdima alexdima added this to the August 2016 milestone Aug 16, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense box (Ctrl+Space) is broken in IE11
3 participants