Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dirSep variable for launch.json #105887

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Add dirSep variable for launch.json #105887

merged 3 commits into from
Nov 12, 2020

Conversation

nrayburn-tech
Copy link
Contributor

Adds a dirSep variable that can be used in launch.json.

Testing

Modify a launch.json config, so that a / is replaced with ${dirSep}. For example, modifying the Gulp Build program property.
From
"${workspaceFolder}/node_modules/gulp/bin/gulp.js" to "${workspaceFolder}${dirName}node_modules${dirName}gulp${dirName}bin${dirName}gulp.js"

This PR fixes #38381

@weinand weinand added this to the September 2020 milestone Sep 2, 2020
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 2, 2020
@bpasero bpasero modified the milestones: September 2020, October 2020 Oct 6, 2020
@weinand weinand modified the milestones: October 2020, November 2020 Oct 26, 2020
@weinand
Copy link
Contributor

weinand commented Nov 11, 2020

@nrayburn-tech Thanks for the PR.

I suggest to use the name pathSeparator instead of dirSep.
Reasons:

  • PathSeparator is the technically correct and more commonly used term.
  • we try to avoid abbreviations in variables names (yes, there are exceptions - but for historical reasons...)

Could you please update your PR?

@weinand weinand merged commit b0ce554 into microsoft:master Nov 12, 2020
@weinand
Copy link
Contributor

weinand commented Nov 12, 2020

@nrayburn-tech thanks for the PR.
I have renamed your dirSep to the suggest pathSeparator .

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we get a ${dirSep} variable for use in tasks.json and launch.json?
4 participants