improve terminal link keyboard navigation experience #140121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
Tyriar
requested changes
Jan 4, 2022
src/vs/workbench/contrib/terminal/browser/links/terminalLinkQuickpick.ts
Outdated
Show resolved
Hide resolved
Comment on lines
101
to
103
| const wordLinks = (await new Promise<ILink[] | undefined>(r => this._standardLinkProviders.get(TerminalWordLinkProvider.id)?.provideLinks(y, r))); | ||
| let webLinks = (await new Promise<ILink[] | undefined>(r => this._standardLinkProviders.get(TerminalProtocolLinkProvider.id)?.provideLinks(y, r))); | ||
| let fileLinks = (await new Promise<ILink[] | undefined>(r => this._standardLinkProviders.get(TerminalValidatedLocalLinkProvider.id)?.provideLinks(y, r))); |
There was a problem hiding this comment.
Using Promise.all here would be best so we can do these in parallel
There was a problem hiding this comment.
can't do that since we want to keep them separate
There was a problem hiding this comment.
Could do it on the side of whatever consumed the getLinks call though: Promise.all([getLinks(...), getLinks(...)]), this is mainly an issue when extension link providers come in (more than 1 slow provider).
There was a problem hiding this comment.
referenced in the extension issue.
src/vs/workbench/contrib/terminal/browser/links/terminalLinkQuickpick.ts
Outdated
Show resolved
Hide resolved
|
Once we merge this in I can give it a quick test run. |
|
@isidorn went with option 1, give it a test in Insider's tomorrow pls and let us know what you think #95570 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #95570