-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable translations for extension code for the web #155355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super reasonable! I just left a couple of comments. Once you tackle those, could we please create a build with this so we could test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Actually this PR doesn't take advantage of vscode-nls 5.1.0 yet so this can just be merged in independently |
* Initial attempt * alex feedback
This PR fixes #
Depends on microsoft/vscode-nls#42
In short, the strategy is to load the message bundles ahead of time and then when the extension is getting loaded, return the pre-loaded strings.
The strategies are slightly different because the scanners are slightly different:
Please review this very harshly. This is code I am unfamiliar with and is owned by several folks.