Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re #134853. Support html headers in notebook outline #160240

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Re #134853. Support html headers in notebook outline #160240

merged 1 commit into from
Sep 7, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Sep 7, 2022

Start with a simple regex parsing for html headers (h1 to h6). It works fine then we don't need to request full markdown rendering, which is async and can be slow.

@rebornix rebornix enabled auto-merge (squash) September 7, 2022 00:53
@rebornix rebornix self-assigned this Sep 7, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the September 2022 milestone Sep 7, 2022
roblourens
roblourens approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with a simple regex parsing for html

Well I can't think of anything that could go wrong 😁

@rebornix rebornix merged commit dd9e590 into main Sep 7, 2022
@rebornix rebornix deleted the rebornix/instant-lynx branch September 7, 2022 01:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@rebornix @roblourens @VSCodeTriageBot