Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tasks status incorrect #163393 #163952

Merged
merged 7 commits into from
Nov 3, 2022
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 18, 2022

Fixes #163393

How to Test

Open vscode with source with tasks.json defined like below, tasks status should be correct after task is done

(Use cmd+shift+b to start task)

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo11",
            "type": "shell",
            "command": "${workspaceFolder}/a.sh",
            "presentation": {
                "echo": true,
                "reveal": "always",
                "focus": false,
                "panel": "new",
                "showReuseMessage": true,
                "clear": false
            },
            "problemMatcher": [],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo11",
            "type": "shell",
            "command": "${workspaceFolder}/a.sh",
            "presentation": {
                "echo": true,
                "reveal": "always",
                "focus": false,
                "showReuseMessage": true,
                "clear": false
            },
            "problemMatcher": [],
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "runOptions": {
                "instanceLimit": 3
            }
        }
    ]
}

File a.sh can be like

echo hello
sleep 3

Co-authored-by: jeanp413 <jeanp413@hotmail.com>
@mustard-mh
Copy link
Contributor Author

@microsoft-github-policy-service agree

1 similar comment
@mustard-mh
Copy link
Contributor Author

@microsoft-github-policy-service agree

@mustard-mh
Copy link
Contributor Author

Updated, see diff here, and local integration test passed

@mustard-mh mustard-mh changed the title Fix tasks status not correct #163393 Fix tasks status not correct https://github.com/microsoft/vscode/issues/163393 Oct 19, 2022
@mustard-mh mustard-mh changed the title Fix tasks status not correct https://github.com/microsoft/vscode/issues/163393 Fix tasks status incorrect #163393 Oct 19, 2022
@jeanp413
Copy link
Contributor

jeanp413 commented Nov 2, 2022

cc @meganrogge

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍🏼

@meganrogge meganrogge added this to the November 2022 milestone Nov 2, 2022
@meganrogge meganrogge merged commit 1aaf61f into microsoft:main Nov 3, 2022
@mustard-mh mustard-mh deleted the hw/fix-task branch November 7, 2022 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell Task Status is not correct
4 participants