Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inlineCompletionsNew proposal. Fixes #164856 #165044

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

hediet
Copy link
Member

@hediet hediet commented Oct 31, 2022

Remove inlineCompletionsNew proposal. Fixes #164856

@hediet hediet enabled auto-merge (squash) October 31, 2022 11:27
@hediet hediet self-assigned this Oct 31, 2022
@hediet hediet requested a review from jrieken October 31, 2022 11:27
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Oct 31, 2022
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to follow-up with the allow lists on product.json. I see this proposal still being referenced and we should clean up there too.

@@ -1184,110 +1184,6 @@ class InlineCompletionAdapter extends InlineCompletionAdapterBase {
}
}

class InlineCompletionAdapterNew extends InlineCompletionAdapterBase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove/inline InlineCompletionAdapterBase?

@hediet hediet merged commit 50b1bcc into main Oct 31, 2022
@hediet hediet deleted the hediet/spontaneous-harrier branch October 31, 2022 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inlineCompletionsNew proposal
3 participants