-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type ResizableContentWidget - using it for the content hover widget #178811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implement the resizable hover and the resizable suggest widget
…nt widget appear, now need to resize is correctly
…factors into an inteface
drefcot17th
previously approved these changes
Apr 1, 2023
… content widget of the resizable hover widget
…tentChanged function
aiday-mar
added
editor-hover
Editor mouse hover
feature-request
Request for new features or functionality
labels
Jun 16, 2023
aiday-mar
changed the title
Adding a ResizableContentWidget type and using it for the resizable content hover
Adding a ResizableContentWidget type, using it for the Hover Widget
Jun 16, 2023
aiday-mar
changed the title
Adding a ResizableContentWidget type, using it for the Hover Widget
Adding a ResizableContentWidget type - using it for the Hover Widget
Jun 16, 2023
aiday-mar
changed the title
Adding a ResizableContentWidget type - using it for the Hover Widget
Adding type ResizableContentWidget - using it for the Hover Widget
Jun 16, 2023
aiday-mar
changed the title
Adding type ResizableContentWidget - using it for the Hover Widget
Adding type ResizableContentWidget - using it for the content hover widget
Jun 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14165
This PR defines the types
ResizableContentWidget
which can be used to implement resizable content widgets. The PR also introduces theSingleSizePersistingMechanism
and theMultipleSizePersistingMechanism
which can be used to define method for persisting the widget sizes. The first class saves a single persisted size while the second class saves persisted sizes on a per-token basis.In addition to these abstractions, the PR also adds the possibility to resize the content hover. It uses the above abstractions. Some notes about the PR:
Below you may find an example of the content hover resizing.
Screen.Recording.2023-03-23.at.16.16.14.mov