Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug session: use queue to make sure debugee status get processed in correct order #180410

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

FlorentRevest
Copy link
Contributor

Similarly to fed69ad, this adds a queue to serialize the processing of pause/continue events. Without this, if a pause and continue events are sent really fast, the pause handler will take longer to process than the continue handler and the state of the debugger UI will be paused when the debuggee is actually running.

Fixes #180409

… correct order

Similarly to fed69ad, this adds a queue to serialize the processing
of pause/continue events. Without this, if a pause and continue events
are sent really fast, the pause handler will take longer to process than
the continue handler and the state of the debugger UI will be paused
when the debuggee is actually running.

Fixes #180409
@FlorentRevest
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Google"

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and analysis, thanks for the PR!

@roblourens roblourens added this to the April 2023 milestone Apr 21, 2023
@roblourens roblourens merged commit 60ce77c into microsoft:main Apr 21, 2023
roblourens added a commit that referenced this pull request May 9, 2023
roblourens added a commit that referenced this pull request May 9, 2023
roblourens added a commit that referenced this pull request May 9, 2023
roblourens added a commit that referenced this pull request May 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent debugger status when debuggee is paused/continued really fast
3 participants