Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow negative numbers for go to match #180479

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Allow negative numbers for go to match #180479

merged 1 commit into from
Apr 24, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Apr 21, 2023

Fixes #180475

Also fixes the case where there are zero matches, which previously resulted in a non-functional quick input

@mjbvz
Allow negative numbers for go to match
1c988c1 
Fixes microsoft#180475

Also fixes the case where there are zero matches, which previously resulted in a non-functional quick input
@mjbvz mjbvz added this to the April 2023 milestone Apr 21, 2023
@mjbvz mjbvz requested a review from rebornix April 21, 2023 06:51
@mjbvz mjbvz self-assigned this Apr 21, 2023
@mjbvz mjbvz enabled auto-merge (squash) April 21, 2023 06:51
rebornix
rebornix approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's creative to use -1.

@mjbvz mjbvz merged commit 1b6bf15 into microsoft:main Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

Go to match should support negative numbers
2 participants
@mjbvz @rebornix