Support : in values for VSCODE_ENV_* variables #182781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
approved these changes
May 17, 2023
| @@ -25,23 +25,23 @@ if ($env:VSCODE_ENV_REPLACE) { | |||
| $Split = $env:VSCODE_ENV_REPLACE.Split(":") | |||
| foreach ($Item in $Split) { | |||
| $Inner = $Item.Split('=') | |||
| [Environment]::SetEnvironmentVariable($Inner[0], $Inner[1]) | |||
| [Environment]::SetEnvironmentVariable($Inner[0], $Inner[1].Replace('\x3a', ':')) | |||
There was a problem hiding this comment.
Can you clarify what this does?
There was a problem hiding this comment.
When vscode sets the variable it will ensure all values have : encoded as \x3a', so to test this out you'll want to encode the values like this:
VAR1=VAL1:VAR2=http\x3a//github.com
There was a problem hiding this comment.
We do it this way because we can't pass \0 into environment variables and splitting multi-character strings is tricky in some shells.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181934
Part of #179476
cc @karrtikr