-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnvironmentVariableMutatorOptions API proposal #182883
Conversation
/** | ||
* Apply to the environment just before the process is created. | ||
* | ||
* Defaults to true. | ||
*/ | ||
applyAtProcessCreation?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not following: https://github.com/Microsoft/vscode/wiki/Extension-API-guidelines#undefined-is-false, are we okay with it in API sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's bring this up at the API sync, undefined not being true would be harmful here imo.
this._setIfDiffers(variable, { value, type: EnvironmentVariableMutatorType.Replace, scope }); | ||
replace(variable: string, value: string, options: vscode.EnvironmentVariableMutatorOptions | undefined, scope: vscode.EnvironmentVariableScope | undefined): void { | ||
if (this._extension && options) { | ||
isProposedApiEnabled(this._extension, 'envCollectionOptions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tyriar This seems to return a boolean but isn't consumed anywhere, did we mean to use checkProposedApiEnabled
instead? Same for other places it's used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it in #183255.
Part of #179476