Update proposed scoped environment collection API #190532

karrtikr · 2023-08-15T23:03:02Z

src/vscode-dts/vscode.proposed.envCollectionWorkspace.d.ts

karrtikr

After this is merged, I plan to stabilize the API tomorrow after testing the updated proposed API in the Python extension.

Update scoped environment collection API

02c388c

mjbvz previously approved these changes Aug 15, 2023

View reviewed changes

Fix compile errors

61011c8

karrtikr dismissed mjbvz’s stale review via 61011c8 August 15, 2023 23:18

Fix test

7c57763

vscodenpa assigned karrtikr Aug 16, 2023

karrtikr requested a review from mjbvz August 16, 2023 00:22

mjbvz previously approved these changes Aug 16, 2023

View reviewed changes

Tyriar reviewed Aug 18, 2023

View reviewed changes

src/vscode-dts/vscode.proposed.envCollectionWorkspace.d.ts Show resolved Hide resolved

Tyriar added this to the August 2023 milestone Aug 18, 2023

Doc review

6d8b0c4

karrtikr dismissed mjbvz’s stale review via 6d8b0c4 August 22, 2023 18:51

karrtikr requested review from Tyriar and mjbvz August 22, 2023 18:52

Only one new line character in case there is no description

6a6dc14

karrtikr marked this pull request as ready for review August 22, 2023 19:25

karrtikr changed the title ~~Update scoped environment collection API~~ Update proposed scoped environment collection API Aug 22, 2023

karrtikr commented Aug 22, 2023

View reviewed changes

Tyriar approved these changes Aug 22, 2023

View reviewed changes

karrtikr merged commit f40dabc into main Aug 22, 2023

karrtikr deleted the kartik1/something branch August 22, 2023 20:19

github-actions bot locked and limited conversation to collaborators Oct 6, 2023

Provide feedback