Sticky Scroll Tree View

[benibenj]

Sticky Scroll in Trees! #161207

[benibenj]

@alexr00 Please have a look at the changes I made in TreeView.ts. The change is that a TreeItem can now be rendered multiple times. A rendered item can be identified by it's handle and templateData.

[alexr00]

treeView.ts changes look good!

[joaomoreno]

Getting there, and feels really good so far.

Here's a bug:

Screen.Recording.2023-11-17.at.14.56.29.mov

Also, did you think about the "now renderers need to worry about renderElement being called twice (once normal and once sticky)" problem that we talked about? We only fixed it on the TreeRenderer._renderedElements property, though this is an established pattern across many tree renderers in the workbench. We need to go around those renderers and understand if they will hit issues as well.

[benibenj]

This is the list of Renderers that probably need to be adapted:

• TreeView
• FilesRenderer
• ResourceMarkersRenderer
• ActionButtonRenderer
• InputRenderer
• ResourceRenderer: No change required, uses template as identifier (is unique across renders of same item)
• ChatListItemRenderer: No change required

// cc @lszomoru

[joaomoreno]

Very cool, getting close.

I think the focus revealing feature should be aware of sticky scrolling somehow. Notice how as I press UpArrow the elements behind sticky scrolling do not get revealed:

Screen.Recording.2023-11-20.at.16.39.24.mov

The same underlying issue causes the rename action on sticky scroll elements to break. In the following recording, the sticky row goes into "editing" mode (I guess this is a bug in itself... should renderers be aware that they are rendering for sticky scroll and avoid doing specific things, like rendering an editable element, in the explorer's case?), and the actual row fails to be properly revealed:

Screen.Recording.2023-11-20.at.16.47.03.mov

Also, the sticky scroll container seems to overlay the list focus outline:

We should also make the sticky rows accessible. They should be focusable (via Shift Tab, when focused in the tree) and navigable using the arrow keys.

resolved