refactor: xterm suggestion addon into terminalContrib #200107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
|
@Tyriar for review |
Tyriar
approved these changes
Dec 7, 2023
Comment on lines
+329
to
+330
| private readonly _onDidSendText = this._register(new Emitter<string>()); | ||
| readonly onDidSendText = this._onDidSendText.event; |
There was a problem hiding this comment.
We can combine this with onDidInputData, I'll handle this in #200242
alexr00
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
SuggestAddonfor the terminal into a terminalContrib to remove any dependencies of the terminal on the suggestion modelTesting
Part of #154662