Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate tslint #2030

Merged
merged 4 commits into from
Jan 18, 2016
Merged

Integrate tslint #2030

merged 4 commits into from
Jan 18, 2016

Conversation

egamma
Copy link
Member

@egamma egamma commented Jan 14, 2016

This PR integrates tslint.

It adds:

  • a tslint.json file. The rules defined in the tslint.json file are currently minimal. The only rule enabled is the no-unused-variable.
  • gulp tslint runs tslint across the vscode base.
  • a task to run tslint from inside Code.
  • the microsoft tslint rule extensions. The rules are currently not used, but they will enable us to use rules like promise-must-complete.

To get tslint checking as you type you need to install the vscode-tslint.

@egamma egamma added the vscode-build VS Code build process issues label Jan 14, 2016
@bpasero
Copy link
Member

bpasero commented Jan 14, 2016

The rules I used for selfhost once are:

{
    "rules": {
        "no-duplicate-variable": true,
        "no-unreachable": true,
        "no-unused-expression": true,
        "no-unused-variable": true,
        "no-var-keyword": true,
        "no-use-before-declare": true,
        "curly": true,
        "semicolon": true
    }
}

@joaomoreno joaomoreno added this to the Jan 2016 milestone Jan 14, 2016
@egamma
Copy link
Member Author

egamma commented Jan 15, 2016

Looks like the build failed due to an error in getting oniguruma.

@joaomoreno joaomoreno merged commit c22706e into master Jan 18, 2016
@joaomoreno joaomoreno deleted the enable-tslint branch January 18, 2016 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants