Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Multi Select #211712

Merged
merged 17 commits into from
May 13, 2024
Merged

Tabs Multi Select #211712

merged 17 commits into from
May 13, 2024

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Apr 30, 2024

This pull request adds multi-select functionality to the editor tabs. Users can now select multiple editor tabs at once and perform actions on them, such as closing or moving them.

To not make this PR even larger it is just a first step with the main behaviour of multi select.
There are more changes to come:

  • UX design (new theme colors, ...)
  • Sync with Open Editors View
  • Add more actions / make sure all actions are supported

fixes #119327

@benibenj benibenj self-assigned this Apr 30, 2024
@benibenj benibenj requested a review from bpasero May 7, 2024 09:32
@benibenj benibenj marked this pull request as ready for review May 7, 2024 09:32
@benibenj benibenj enabled auto-merge (squash) May 7, 2024 09:32
@vscodenpa vscodenpa added this to the May 2024 milestone May 7, 2024
bpasero
bpasero previously requested changes May 8, 2024
src/vs/workbench/common/theme.ts Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editor.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorDropTarget.ts Outdated Show resolved Hide resolved
@benibenj benibenj dismissed bpasero’s stale review May 13, 2024 16:14

We discussed all concerns and agreed on this approach. Dismissing to get into tomorrows insiders

@benibenj benibenj merged commit 88bc75f into main May 13, 2024
6 checks passed
@benibenj benibenj deleted the benibenj/quixotic-salmon branch May 13, 2024 19:06
@starball5
Copy link

Fixes #50713

@bpasero
Copy link
Member

bpasero commented May 17, 2024

Remaining review comments have moved to #212930

@microsoft microsoft locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to select multiple tabs for operations such as move / compare
5 participants