Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple extensions to provide default values for object settings #217179

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

benibenj
Copy link
Contributor

This pull request enables multiple extensions to provide default values for object settings. Previously, only one extension could provide a default value for an object setting.

We now also track the source of default value in object settings and display them in the hover in the Settings editor.

fixes #211632

@benibenj benibenj self-assigned this Jun 24, 2024
@benibenj benibenj enabled auto-merge (squash) June 24, 2024 13:21
@vscodenpa vscodenpa added this to the June 2024 milestone Jun 24, 2024
sandy081
sandy081 previously approved these changes Jun 24, 2024
@benibenj benibenj merged commit aef2886 into main Jun 24, 2024
6 checks passed
@benibenj benibenj deleted the benibenj/radical-skink branch June 24, 2024 21:19
bricefriha pushed a commit to bricefriha/vscode that referenced this pull request Jun 26, 2024
…gs (microsoft#217179)

* Allow multiple extensions to provide default values for object settings

* Fix merge conflict

* type check

* fix tests
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
…gs (microsoft#217179)

* Allow multiple extensions to provide default values for object settings

* Fix merge conflict

* type check

* fix tests
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Labels: Allow multiple extensions to contribute Patterns
4 participants