Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nb multiselect support for core editor actions + arrow navigation #228032

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

Yoyokrazy
Copy link
Contributor

Re: #141673

cc/ @alexdima for some of the work regarding relaying editor events. This is to unblock core editor actions, but more thought will be required to pursue all editor commands (as they require selections from an editor, which outside of the viewport would not be available).

@Yoyokrazy Yoyokrazy self-assigned this Sep 9, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 9, 2024
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The editor core change looks clean. I also can't come up with a better way to accomplish what you're trying to do, so LGTM.

Appologies for the slow review ❤️

@Yoyokrazy Yoyokrazy merged commit 4b10d94 into main Sep 13, 2024
7 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/nb-multicursor-plus branch September 13, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants