-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rectangle renderer and gpu rulers view part #228632
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4eb785e
Rectangles initial
Tyriar 88fd73d
Add IObjectCollectionBuffer.entryCount
Tyriar 8ac4186
Use pixel coordinates for rectangles
Tyriar 330004b
Add rectangle color
Tyriar b10b656
Simplify wgsl position calculation
Tyriar 2cd41ff
Create gpu rulers
Tyriar 5145052
Add rulers GPU component
Tyriar 9d7e4e9
Use viewport content left in rectangle renderer
Tyriar 60012f8
setRaw data in rulers and use observables
Tyriar ec3c394
Start of scroll support
Tyriar f962d91
Set correct buffer length based on instance capacity
Tyriar 61f3f97
Set ruler height to max height
Tyriar c6c2868
Merge branch 'main' into tyriar/221211
Tyriar 2ecac35
Only update scroll buffer on scroll
Tyriar 6a3435c
Update scroll left in main render strategy
Tyriar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,274 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.txt in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import { getActiveWindow } from '../../../base/browser/dom.js'; | ||
import { EditorOption } from '../../common/config/editorOptions.js'; | ||
import { ViewEventHandler } from '../../common/viewEventHandler.js'; | ||
import type { ViewScrollChangedEvent } from '../../common/viewEvents.js'; | ||
import type { ViewportData } from '../../common/viewLayout/viewLinesViewportData.js'; | ||
import type { ViewContext } from '../../common/viewModel/viewContext.js'; | ||
import { GPULifecycle } from './gpuDisposable.js'; | ||
import { observeDevicePixelDimensions, quadVertices } from './gpuUtils.js'; | ||
import { createObjectCollectionBuffer, type IObjectCollectionBuffer, type IObjectCollectionBufferEntry } from './objectCollectionBuffer.js'; | ||
import { RectangleRendererBindingId, rectangleRendererWgsl } from './rectangleRenderer.wgsl.js'; | ||
|
||
export type RectangleRendererEntrySpec = [ | ||
{ name: 'x' }, | ||
{ name: 'y' }, | ||
{ name: 'width' }, | ||
{ name: 'height' }, | ||
{ name: 'red' }, | ||
{ name: 'green' }, | ||
{ name: 'blue' }, | ||
{ name: 'alpha' }, | ||
]; | ||
|
||
export class RectangleRenderer extends ViewEventHandler { | ||
|
||
private _device!: GPUDevice; | ||
private _renderPassDescriptor!: GPURenderPassDescriptor; | ||
private _renderPassColorAttachment!: GPURenderPassColorAttachment; | ||
private _bindGroup!: GPUBindGroup; | ||
private _pipeline!: GPURenderPipeline; | ||
|
||
private _vertexBuffer!: GPUBuffer; | ||
private _shapeBindBuffer!: GPUBuffer; | ||
|
||
private _scrollOffsetBindBuffer!: GPUBuffer; | ||
private _scrollOffsetValueBuffer!: Float32Array; | ||
|
||
private _initialized: boolean = false; | ||
private _scrollChanged: boolean = true; | ||
|
||
private readonly _shapeCollection: IObjectCollectionBuffer<RectangleRendererEntrySpec> = this._register(createObjectCollectionBuffer([ | ||
{ name: 'x' }, | ||
{ name: 'y' }, | ||
{ name: 'width' }, | ||
{ name: 'height' }, | ||
{ name: 'red' }, | ||
{ name: 'green' }, | ||
{ name: 'blue' }, | ||
{ name: 'alpha' }, | ||
], 32)); | ||
|
||
constructor( | ||
private readonly _context: ViewContext, | ||
private readonly _canvas: HTMLCanvasElement, | ||
private readonly _ctx: GPUCanvasContext, | ||
device: Promise<GPUDevice>, | ||
) { | ||
super(); | ||
|
||
this._context.addEventHandler(this); | ||
|
||
this._initWebgpu(device); | ||
} | ||
|
||
private async _initWebgpu(device: Promise<GPUDevice>) { | ||
|
||
// #region General | ||
|
||
this._device = await device; | ||
|
||
if (this._store.isDisposed) { | ||
return; | ||
} | ||
|
||
const presentationFormat = navigator.gpu.getPreferredCanvasFormat(); | ||
this._ctx.configure({ | ||
device: this._device, | ||
format: presentationFormat, | ||
alphaMode: 'premultiplied', | ||
}); | ||
|
||
this._renderPassColorAttachment = { | ||
view: null!, // Will be filled at render time | ||
loadOp: 'load', | ||
storeOp: 'store', | ||
}; | ||
this._renderPassDescriptor = { | ||
label: 'Monaco rectangle renderer render pass', | ||
colorAttachments: [this._renderPassColorAttachment], | ||
}; | ||
|
||
// #endregion General | ||
|
||
// #region Uniforms | ||
|
||
let layoutInfoUniformBuffer: GPUBuffer; | ||
{ | ||
const enum Info { | ||
FloatsPerEntry = 6, | ||
BytesPerEntry = Info.FloatsPerEntry * 4, | ||
Offset_CanvasWidth____ = 0, | ||
Offset_CanvasHeight___ = 1, | ||
Offset_ViewportOffsetX = 2, | ||
Offset_ViewportOffsetY = 3, | ||
Offset_ViewportWidth__ = 4, | ||
Offset_ViewportHeight_ = 5, | ||
} | ||
const bufferValues = new Float32Array(Info.FloatsPerEntry); | ||
const updateBufferValues = (canvasDevicePixelWidth: number = this._canvas.width, canvasDevicePixelHeight: number = this._canvas.height) => { | ||
bufferValues[Info.Offset_CanvasWidth____] = canvasDevicePixelWidth; | ||
bufferValues[Info.Offset_CanvasHeight___] = canvasDevicePixelHeight; | ||
bufferValues[Info.Offset_ViewportOffsetX] = Math.ceil(this._context.configuration.options.get(EditorOption.layoutInfo).contentLeft * getActiveWindow().devicePixelRatio); | ||
bufferValues[Info.Offset_ViewportOffsetY] = 0; | ||
bufferValues[Info.Offset_ViewportWidth__] = bufferValues[Info.Offset_CanvasWidth____] - bufferValues[Info.Offset_ViewportOffsetX]; | ||
bufferValues[Info.Offset_ViewportHeight_] = bufferValues[Info.Offset_CanvasHeight___] - bufferValues[Info.Offset_ViewportOffsetY]; | ||
return bufferValues; | ||
}; | ||
layoutInfoUniformBuffer = this._register(GPULifecycle.createBuffer(this._device, { | ||
label: 'Monaco rectangle renderer uniform buffer', | ||
size: Info.BytesPerEntry, | ||
usage: GPUBufferUsage.UNIFORM | GPUBufferUsage.COPY_DST, | ||
}, () => updateBufferValues())).object; | ||
this._register(observeDevicePixelDimensions(this._canvas, getActiveWindow(), (w, h) => { | ||
this._device.queue.writeBuffer(layoutInfoUniformBuffer, 0, updateBufferValues(w, h)); | ||
})); | ||
} | ||
|
||
const scrollOffsetBufferSize = 2; | ||
this._scrollOffsetBindBuffer = this._register(GPULifecycle.createBuffer(this._device, { | ||
label: 'Monaco rectangle renderer scroll offset buffer', | ||
size: scrollOffsetBufferSize * Float32Array.BYTES_PER_ELEMENT, | ||
usage: GPUBufferUsage.UNIFORM | GPUBufferUsage.COPY_DST, | ||
})).object; | ||
this._scrollOffsetValueBuffer = new Float32Array(scrollOffsetBufferSize); | ||
|
||
// #endregion Uniforms | ||
|
||
// #region Storage buffers | ||
|
||
this._shapeBindBuffer = this._register(GPULifecycle.createBuffer(this._device, { | ||
label: 'Monaco rectangle renderer shape buffer', | ||
size: this._shapeCollection.buffer.byteLength, | ||
usage: GPUBufferUsage.STORAGE | GPUBufferUsage.COPY_DST, | ||
})).object; | ||
|
||
// #endregion Storage buffers | ||
|
||
// #region Vertex buffer | ||
|
||
this._vertexBuffer = this._register(GPULifecycle.createBuffer(this._device, { | ||
label: 'Monaco rectangle renderer vertex buffer', | ||
size: quadVertices.byteLength, | ||
usage: GPUBufferUsage.VERTEX | GPUBufferUsage.COPY_DST, | ||
}, quadVertices)).object; | ||
|
||
// #endregion Vertex buffer | ||
|
||
// #region Shader module | ||
|
||
const module = this._device.createShaderModule({ | ||
label: 'Monaco rectangle renderer shader module', | ||
code: rectangleRendererWgsl, | ||
}); | ||
|
||
// #endregion Shader module | ||
|
||
// #region Pipeline | ||
|
||
this._pipeline = this._device.createRenderPipeline({ | ||
label: 'Monaco rectangle renderer render pipeline', | ||
layout: 'auto', | ||
vertex: { | ||
module, | ||
buffers: [ | ||
{ | ||
arrayStride: 2 * Float32Array.BYTES_PER_ELEMENT, // 2 floats, 4 bytes each | ||
attributes: [ | ||
{ shaderLocation: 0, offset: 0, format: 'float32x2' }, // position | ||
], | ||
} | ||
] | ||
}, | ||
fragment: { | ||
module, | ||
targets: [ | ||
{ | ||
format: presentationFormat, | ||
blend: { | ||
color: { | ||
srcFactor: 'src-alpha', | ||
dstFactor: 'one-minus-src-alpha' | ||
}, | ||
alpha: { | ||
srcFactor: 'src-alpha', | ||
dstFactor: 'one-minus-src-alpha' | ||
}, | ||
}, | ||
} | ||
], | ||
}, | ||
}); | ||
|
||
// #endregion Pipeline | ||
|
||
// #region Bind group | ||
|
||
this._bindGroup = this._device.createBindGroup({ | ||
label: 'Monaco rectangle renderer bind group', | ||
layout: this._pipeline.getBindGroupLayout(0), | ||
entries: [ | ||
{ binding: RectangleRendererBindingId.Shapes, resource: { buffer: this._shapeBindBuffer } }, | ||
{ binding: RectangleRendererBindingId.LayoutInfoUniform, resource: { buffer: layoutInfoUniformBuffer } }, | ||
{ binding: RectangleRendererBindingId.ScrollOffset, resource: { buffer: this._scrollOffsetBindBuffer } }, | ||
], | ||
}); | ||
|
||
// endregion Bind group | ||
|
||
this._initialized = true; | ||
} | ||
|
||
register(x: number, y: number, width: number, height: number, red: number, green: number, blue: number, alpha: number): IObjectCollectionBufferEntry<RectangleRendererEntrySpec> { | ||
// TODO: Expand buffer if needed | ||
return this._shapeCollection.createEntry({ x, y, width, height, red, green, blue, alpha }); | ||
} | ||
|
||
// --- begin event handlers | ||
|
||
public override onScrollChanged(e: ViewScrollChangedEvent): boolean { | ||
this._scrollChanged = true; | ||
return super.onScrollChanged(e); | ||
} | ||
|
||
// --- end event handlers | ||
|
||
private _update() { | ||
// TODO: Only write dirty range | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
this._device.queue.writeBuffer(this._shapeBindBuffer, 0, this._shapeCollection.buffer); | ||
|
||
// Update scroll offset | ||
if (this._scrollChanged) { | ||
const dpr = getActiveWindow().devicePixelRatio; | ||
this._scrollOffsetValueBuffer[0] = this._context.viewLayout.getCurrentScrollLeft() * dpr; | ||
this._scrollOffsetValueBuffer[1] = this._context.viewLayout.getCurrentScrollTop() * dpr; | ||
this._device.queue.writeBuffer(this._scrollOffsetBindBuffer, 0, this._scrollOffsetValueBuffer); | ||
} | ||
} | ||
|
||
draw(viewportData: ViewportData) { | ||
if (!this._initialized) { | ||
return; | ||
} | ||
|
||
this._update(); | ||
|
||
const encoder = this._device.createCommandEncoder({ label: 'Monaco rectangle renderer command encoder' }); | ||
|
||
this._renderPassColorAttachment.view = this._ctx.getCurrentTexture().createView(); | ||
const pass = encoder.beginRenderPass(this._renderPassDescriptor); | ||
pass.setPipeline(this._pipeline); | ||
pass.setVertexBuffer(0, this._vertexBuffer); | ||
pass.setBindGroup(0, this._bindGroup); | ||
|
||
pass.draw(quadVertices.length / 2, this._shapeCollection.entryCount); | ||
pass.end(); | ||
|
||
const commandBuffer = encoder.finish(); | ||
this._device.queue.submit([commandBuffer]); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#228834