Fix TS 2.3.1 Compiler Errors in VSCode src/workbench #25249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
force-pushed
the
ts-231-vscode-workbench-fixes
branch
2 times, most recently
from
f01cb3e
to
9475058
Compare
|
I'm going to revert the changes around |
mjbvz
force-pushed
the
ts-231-vscode-workbench-fixes
branch
2 times, most recently
from
c63b518
to
1871615
Compare
mjbvz
commented
Apr 24, 2017
| @@ -310,7 +310,7 @@ export class ExtHostSCM { | |||
| return sourceControl; | |||
| } | |||
|
|
|||
| $provideOriginalResource(sourceControlHandle: number, uri: URI): TPromise<URI> { | |||
There was a problem hiding this comment.
I also wasn't entirely sure of URI vs vscode.Uri. I think the change itself is correct, but I was not confident to know if any existing code is relying on the old signature or if this change could cause any trouble
There was a problem hiding this comment.
Good catch. Both URI there should be vscode.Uri.
jrieken
approved these changes
Apr 25, 2017
joaomoreno
approved these changes
Apr 25, 2017
| @@ -310,7 +310,7 @@ export class ExtHostSCM { | |||
| return sourceControl; | |||
| } | |||
|
|
|||
| $provideOriginalResource(sourceControlHandle: number, uri: URI): TPromise<URI> { | |||
There was a problem hiding this comment.
Good catch. Both URI there should be vscode.Uri.
|
Looks good, thanks! |
isidorn
approved these changes
Apr 25, 2017
TS 2.3.1 introduced a breaking change by [switching to covariant types for callbacks](https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#covariance-in-callback-parameters). This change tries to fix these compiler errors in the workbench codebase
mjbvz
force-pushed
the
ts-231-vscode-workbench-fixes
branch
from
1871615
to
d65b4e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: microsoft/TypeScript#15352
TS 2.3.1 introduced a breaking change by switching to covariant types for callbacks. This change tries to fix these compiler errors in the workbench codebase