Update paths.js to allow use of ENV variable as alternative to cmd args #26848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…override for userDataPath This patch allows defining the environment variable "vscode_config_prefix" as a global default, instead of relying on command line arguments. The solution is similar to NPM's npm_config_prefix environment variable. if defined, APPDATA, XDG_CONFIG_HOME, and other solutions are ignored for determining the path value. This is 1/2 the solution to removing the user data from the Windows roaming profile.
|
@apwelsh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @bpasero to be potential reviewers. |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
joaomoreno
added
the
under-discussion
|
Let's discuss this in #26849 as well. |
|
I've renamed the variable to Thanks! 🍻 |
|
Thanks. Makes sense. I modeled the variable names off of npm / yarn naming conventions. I look forward to the deployment of the build that has this enhancement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…override for userDataPath
This patch allows defining the environment variable "vscode_config_prefix" as a global default, instead of relying on command line arguments. The solution is similar to NPM's npm_config_prefix environment variable. if defined, APPDATA, XDG_CONFIG_HOME, and other solutions are ignored for determining the path value. This is 1/2 the solution to removing the user data from the Windows roaming profile.