[WIP] Inline all decorations - attempt 2

[Krzysztof-Cieslak]

This is follow up on #20042.
Original issue: #19749

CC: @jrieken

This is not ready yet, but I just would love to get some input whether I'm moving in right direction.
Right now I'm just trying to replicate current behavior [without adding possibility to display all errors] but moving implementation to IViewZone as described in comments in original PR.

[mention-bot]

@Krzysztof-Cieslak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

[msftclas]

@Krzysztof-Cieslak,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[jrieken]

Can you resolve conflicts and we start looking into this?

[Krzysztof-Cieslak]

Rebased to latest master

[jrieken]

Your live will be a lot easier if you start fresh and I strongly recommend that. Don't get hung up with massaging the old code, just start with a new thing that simply always shows all errors/warning inline

[Krzysztof-Cieslak]

So I guess the question is whether I should only add new functionality ( inline all errors / warnings) or also try to replace old functionality with implementation using View Zones as suggested in #20042 (comment)

[jrieken]

Sorry, that was misleading. In above mentioned comment I wasn't suggesting to replace the old functionality but to start fresh for this particular feature. The old bits will stay how they are, for the show all errors/warning feature tho we come up with something new (the old might eventually benefit from this)

[Krzysztof-Cieslak]

Oh, no problem. I've might interpreted something wrongly in this comment.

In such case, starting totally fresh definitely makes sense, I'll try to do attempt 3 over the weekend ;)

[Krzysztof-Cieslak]

Closing in favor of #29145