[WIP] Undo/redo history branching #27302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zalastax, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @alexandrudima to be potential reviewers. |
Zalastax
force-pushed
the
master
branch
2 times, most recently
from
35880db to
ae800f1
Compare
This enables multiple redo futures, a feature available in editors such as vim and emacs. Undo branches / undo tree allows you to undo some changes, then make a new change, while keeping all changes available in the undo tree. The undo tree can therefore prevent awkward scenarios such as: * Losing all redo futures by accidentally pressing a button during undo * Copying the file or save it with git when trying multiple alternatives It's implemented by modifying the edit stack elements to keep track of all possible futures, instead of throwing alternative futures away. A new event has been added, notifying all movement in the tree. The method moveTo is used to move to a certain node in the tree, by providing its index (a unique and ordered number). This index is used to find the common ancestor of the current node and the target node. The undo/redo path through the common ancestor is the shortest number of transformations needed to go from the current node to the target. The history tree is visualized in a contrib plugin on two overlayed canvases, to enable some future optimizations. The node position calculation of the visualization is cached, but several more calculations have further optimization potential.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to get feedback in #20889 before opening this PR, as the changes are rather large and needs input from corresponding stakeholders, but I've not gotten a response in months. The issue contains details about what I find unclear / needs improvement so I'll not duplicate that here.