Tab title uses parent for specified file names #30316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sohlex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @alexandrudima to be potential reviewers. |
|
@sohlex, It will cover your contributions to all Microsoft-managed open source projects. |
|
@sohlex, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
sohlex
changed the title
|
Closing in favour of #33815 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take for issues #27328 and #12965.
In the settings is now possible to specify an array of file names, i.e.
"workbench.editor.tabTitleUsesParentFor": ["index.js", "template.hbs"].This controls if we should emphasise parent directory name when there are opened editors with the specified file name.
In the screenshot there's the outcome of this PR: for the files specified, the parent directory is highlighted, for the others nothing changes (so if there's no ambiguity the file name is shown, otherwise the file name + path).
If this approach is considered valid, I'm open to suggestions on how to improve the code. Probably move all the logic inside the already existing method getUniqueTabLabels?