Fix tabbing in trees #32502
Merged
Fix tabbing in trees #32502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lixire
added
terminal
roblourens
reviewed
Aug 14, 2017
| @@ -444,7 +444,7 @@ export class TreeView extends HeightMap { | |||
|
|
|||
| this.domNode = document.createElement('div'); | |||
| this.domNode.className = `monaco-tree no-focused-item monaco-tree-instance-${this.instance}`; | |||
| this.domNode.tabIndex = 0; | |||
| this.domNode.tabIndex = context.options.preventRootFocus ? -1 : 0; | |||
There was a problem hiding this comment.
Is preventRootFocus still a good name for the option? And were you able to figure out why we need the tabIndex for quick navigate?
bpasero
approved these changes
Aug 15, 2017
| @@ -335,7 +336,15 @@ export class QuickOpenWidget implements IModelProvider { | |||
| } | |||
|
|
|||
| this.applyStyles(); | |||
|
|
|||
There was a problem hiding this comment.
@Lixire I prefer to keep the newline here, looks logically too close otherwise imho:
roblourens
approved these changes
Aug 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2: Electric Boogaloo
I changed the tab index to -1 instead of not setting it at all so it can still be focusable which fixes the quick navigate feature.
Fixes #31835 and #31836