Don't try resizing find widget when it is not visible #38651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of microsoft#34744 Don't try to update the width of the find widget when it is not visible. This update function is slow as it relies on `dom.getTotalWidth`
mjbvz
commented
Nov 17, 2017
| @@ -534,6 +495,48 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas | |||
| this._replaceInputBox.style(inputStyles); | |||
| } | |||
|
|
|||
| private _tryUpdateWidgetWidth() { | |||
| if (!this._isVisible) { | |||
There was a problem hiding this comment.
This is the only changed line of the extraction
|
Ping @rebornix in case you only monitor PRs assigned to you (like me) |
|
Thanks @mjbvz , good enhancement ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #34744
Don't try to update the width of the find widget when it is not visible. This update function is slow as it relies on
dom.getTotalWidth