Use issue reporter for settings search #43274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
reviewed
Feb 9, 2018
| query: string; | ||
| filterResultCount: number; | ||
| } | ||
|
|
||
| export interface IIssueService { |
There was a problem hiding this comment.
How about naming the new interface something like IWorkbenchIssueService and keeping the old one as IIssueService? To me, raw sounds like something that would always be wrapped/used as a base, but this is being used directly in the main process
There was a problem hiding this comment.
"Raw" is used in similar situations for search and debug but I'm not sure why... I like IWorkbenchIssueService better.
…simpler interface to launch the issue reporter
…et when the setting is set
roblourens
force-pushed
the
roblou/settingsSearchIssueReporter
branch
from
398a9b1
to
0f513d4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43268
This implements a special mode for the issue reporter to allow filing issues with settings search info. The settings search type is not allowed as an option when opening the reporter through the Help menu, so the select options are set up dynamically. The rest of it is following the pattern of the types that are already there.
Another change is to add a new IssueService to the frontend which gets the theme info, installed extensions, other common stuff to provide a simpler API to code that wants to show the reporter. Another reason for it is that all the settings stuff is in
browser, so it can't directly use the dependencies fromelectron-browserunless I move it all over there, which I want to avoid.