Add onDidChangeActiveEditor API #43803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #43713 Adds a new api `onDidChangeActiveEditor` which generalizes `onDidChangeActiveTextEditor` to also detect switches to and from webviews. This API replaces the `Webview.onBecameActive` and `Webview.onBecameInactive` events previously prototyped.
mjbvz
force-pushed
the
add-on-did-change-active-editor
branch
from
c0a64fa
to
70dac6a
Compare
|
Other APIs to consider for making webviews first class editors: window.showEditor(editor: TextEditor | Webview);
window.onDidChangeVisibleEditors: Event<TextEditor | Webview>
window.onDidChangeEditorViewColumn: Event<...> |
|
@mjbvz I am removing myself as reviewer since the code changed is nothing I own. |
|
Ditto 😄 |
|
Merged into #44165 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43713
Adds a new api
onDidChangeActiveEditorwhich generalizesonDidChangeActiveTextEditorto also detect switches to and from webviews.This API replaces the
Webview.onBecameActiveandWebview.onBecameInactiveevents previously prototyped. We discussed a few alternative designs at the Redmond sitdown, including:onDidChangeActiveWebviewAPI for webviews specificallyonDidChangeActiveTextEditorAPI to support webviewsfocusandblurevents on the webview object itself.We settled on
onDidChangeActiveEditoras it fits with the design of our current APIs while also allowing expansion to support other "Editor" types in the future, such as ones for theOutputor potentially even for the terminal.