Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add following to TreeView #49970

Merged
merged 3 commits into from
May 17, 2018
Merged

Add following to TreeView #49970

merged 3 commits into from
May 17, 2018

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented May 16, 2018

- Events to listen to when an element is expanded/collapsed
- Property to access selected elements
@sandy081 sandy081 requested a review from jrieken May 16, 2018 10:57
@sandy081 sandy081 self-assigned this May 16, 2018
@sandy081 sandy081 added this to the May 2018 milestone May 16, 2018
@sandy081 sandy081 added api tree-views Extension tree view issues labels May 16, 2018
/**
* Currently selected elements.
*/
readonly selectedElements: ReadonlyArray<T>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just selection is better? That;s what we use in the editor. Also, why is it readonly? How do I selecting something in the tree?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, currently there is no direct API to select. reveal has an option to reveal and select. I am sure there will be select api soon and then I can remove readonly once implemented.

@sandy081 sandy081 merged commit fbf1fef into master May 17, 2018
@sandy081 sandy081 deleted the sandy081/treeViewApi branch May 17, 2018 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api tree-views Extension tree view issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants